Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mahalanobis #397

Merged
merged 35 commits into from
Jun 1, 2022
Merged

Mahalanobis #397

merged 35 commits into from
Jun 1, 2022

Conversation

pedrorponga
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #397 (15ceafa) into develop (4e720c3) will increase coverage by 0.06%.
The diff coverage is 89.39%.

@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
+ Coverage    80.30%   80.37%   +0.06%     
===========================================
  Files           93       94       +1     
  Lines         7333     7394      +61     
===========================================
+ Hits          5889     5943      +54     
- Misses        1444     1451       +7     
Impacted Files Coverage Δ
skfda/ml/classification/_depth_classifiers.py 97.18% <ø> (ø)
skfda/misc/metrics/_mahalanobis.py 83.72% <83.72%> (ø)
skfda/exploratory/depth/_depth.py 90.14% <100.00%> (+2.42%) ⬆️
skfda/misc/metrics/_utils.py 72.22% <100.00%> (+1.20%) ⬆️
skfda/ml/classification/_centroid_classifiers.py 100.00% <100.00%> (ø)
skfda/preprocessing/dim_reduction/_fpca.py 91.05% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e720c3...15ceafa. Read the comment docs.

@pedrorponga pedrorponga requested a review from vnmabus November 23, 2021 19:53
docs/modules/misc/metrics.rst Outdated Show resolved Hide resolved
skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
@GAA-UAM GAA-UAM deleted a comment from github-actions bot Apr 6, 2022
@GAA-UAM GAA-UAM deleted a comment from github-actions bot Apr 6, 2022
@GAA-UAM GAA-UAM deleted a comment from github-actions bot Apr 6, 2022
@GAA-UAM GAA-UAM deleted a comment from github-actions bot Apr 6, 2022
skfda/exploratory/depth/_depth.py Outdated Show resolved Hide resolved
skfda/ml/classification/_centroid_classifiers.py Outdated Show resolved Hide resolved
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not taking a look at this before. I though that you would ping me when it was ready to review.

skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/exploratory/depth/_depth.py Outdated Show resolved Hide resolved
@pedrorponga pedrorponga requested a review from vnmabus May 23, 2022 00:53
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the tests pass now, it was a temporary timeout error.

skfda/misc/metrics/_mahalanobis.py Outdated Show resolved Hide resolved
skfda/ml/classification/_centroid_classifiers.py Outdated Show resolved Hide resolved
@pedrorponga pedrorponga requested a review from vnmabus May 30, 2022 16:51
@pedrorponga pedrorponga merged commit a95d675 into develop Jun 1, 2022
@pedrorponga pedrorponga deleted the feature/mahalanobis branch June 1, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants