Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite gomigrate test using testcontainer #355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudiptob2
Copy link
Collaborator

closes #347

@sudiptob2 sudiptob2 force-pushed the test/347/refactor-gomigrate-test branch from 48ef18a to 1ee62ee Compare November 27, 2024 13:43
@sudiptob2 sudiptob2 marked this pull request as ready for review November 27, 2024 13:44
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to test migration when migration is a requirement for all other tests?

@sudiptob2
Copy link
Collaborator Author

Why do we need to test migration when migration is a requirement for all other tests?

Hmm.. Interesting question. It tests migration.Up() and migration.Down() commands that we have. For that reason I think we should keep this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GoMigrate_Integration test using Testcontainer
2 participants