Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish chart to G-Research/charts repository #101

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Publish chart to G-Research/charts repository #101

merged 2 commits into from
Jul 19, 2024

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented Jul 15, 2024

Checks:

  • Create GitHub app required for this process and pass the fingerprint of the created app via comment on this add yunikorn-history-server charts charts#132
    • App created, we have fingerprint too wrNW9GyqMpq4pv1EgXrgwYPweqsHJo2hRzqOMiBYjS8=
  • Create the environment invoke-push and add following secrets from created app
    • APP_ID and APP_PRIVATE_KEY are created under invoke-push environment

Goal of this PR is to use official process of publishing charts to G-Research repo https://g-research.github.io/charts/

@ljubon ljubon marked this pull request as draft July 15, 2024 08:16
@ljubon
Copy link
Contributor Author

ljubon commented Jul 15, 2024

The app is created, environment created, G-Research/charts#132 is merged too
We are ready for review/comment 🫡

@ljubon ljubon marked this pull request as ready for review July 15, 2024 14:29
Copy link
Contributor

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pavlovic-ivan pavlovic-ivan merged commit d76e981 into G-Research:main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants