Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Analyzers.SDK to 0.28.0 #85

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Update FSharp.Analyzers.SDK to 0.28.0 #85

merged 2 commits into from
Nov 20, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 20, 2024

TODO: global.json currently has rollForward set to latestMajor, and if I run that with the .NET 9 SDK installed it falls over that dotnet tool restore bug when trying to restore Fantomas.

Edit: Pinned the SDK to version 8 for now

@nojaf
Copy link
Contributor

nojaf commented Nov 20, 2024

Please pin the latest 8 SDK for now.

@nojaf
Copy link
Contributor

nojaf commented Nov 20, 2024

This looks good, would you mind adding a changelog entry as well?

@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 20, 2024

will do

@Numpsy Numpsy marked this pull request as ready for review November 20, 2024 10:45
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you Richard!

@nojaf nojaf merged commit e4d4c63 into G-Research:main Nov 20, 2024
1 check passed
@Numpsy Numpsy deleted the 9sdk branch November 20, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants