Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false negative in LoggingTemplateMissingValuesAnalyzer #80

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Fix a false negative in LoggingTemplateMissingValuesAnalyzer #80

merged 8 commits into from
Feb 16, 2024

Conversation

dawedawe
Copy link
Contributor

fixes #79

@dawedawe dawedawe requested a review from nojaf February 16, 2024 13:22
nojaf
nojaf approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but probably won't survive the next slight deviation.

@dawedawe dawedawe merged commit ac234ce into main Feb 16, 2024
1 check passed
@dawedawe dawedawe deleted the fix_79 branch February 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential false positive in GRA-LOGTEMPLMISSVALS-001
2 participants
@dawedawe @nojaf