Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use static JsonConvert #417

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Do not use static JsonConvert #417

merged 10 commits into from
Jan 21, 2025

Conversation

marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Jan 21, 2025 •
edited
Loading

Replaces #413

@marcin-krystianc marcin-krystianc marked this pull request as ready for review January 21, 2025 16:23
@marcin-krystianc marcin-krystianc mentioned this pull request Jan 21, 2025
Closed
adamreeve
adamreeve approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcin-krystianc marcin-krystianc merged commit d301762 into master Jan 21, 2025
249 checks passed
@marcin-krystianc marcin-krystianc deleted the dev-20250121-json branch January 21, 2025 20:26
@sungam3r
Copy link
Contributor

@marcin-krystianc thanks for fix. When can you publish this?

@marcin-krystianc
Copy link
Contributor Author

@marcin-krystianc thanks for fix. When can you publish this?

It has been released -> https://www.nuget.org/packages/Consul/1.7.14.7

@sungam3r
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreeve adamreeve adamreeve approved these changes

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcin-krystianc @sungam3r @adamreeve @octocat