Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update .NET versions and reduce test matrix cardinality #416

Merged
merged 31 commits into from
Jan 22, 2025
Merged

[CI] Update .NET versions and reduce test matrix cardinality #416

merged 31 commits into from
Jan 22, 2025

Conversation

marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Jan 21, 2025 •
edited
Loading

  • .NET 8 is the latest LTS
  • .NET 9 is the latest STS (Standard Term Support)
  • .NET 6 and .NET 7 are out of support
  • taking out the macos-13 from the matrix and adding a single job with it to reduce matrix cardinality

@marcin-krystianc marcin-krystianc changed the title [CI] Reduce the cardinality of the matrix strategy [CI] Update .NET versions and reduce tests cardinality Jan 21, 2025
@marcin-krystianc marcin-krystianc changed the title [CI] Update .NET versions and reduce tests cardinality [CI] Update .NET versions and reduce test matrix cardinality Jan 21, 2025
@marcin-krystianc marcin-krystianc marked this pull request as ready for review January 21, 2025 12:35
@marcin-krystianc marcin-krystianc mentioned this pull request Jan 21, 2025
Merged
adamreeve
adamreeve approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking out the macos-13 from the matrix and adding a single job with it to reduce matrix cardinality

Should we do the same thing for Consul_AspNetCore for consistency?

@marcin-krystianc
Copy link
Contributor Author

taking out the macos-13 from the matrix and adding a single job with it to reduce matrix cardinality

Should we do the same thing for Consul_AspNetCore for consistency?

Probably not needed, For Consul_AspNetCore we don't have massive cardinality because we don't run tests for every consul version. I think it is good as it is now.

@marcin-krystianc marcin-krystianc merged commit 86c6c36 into master Jan 22, 2025
109 checks passed
@marcin-krystianc marcin-krystianc deleted the dev-20250121-matrix_strategy branch January 22, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreeve adamreeve adamreeve approved these changes

@jgiannuzzi jgiannuzzi Awaiting requested review from jgiannuzzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcin-krystianc @adamreeve