Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CAGetConfiguration (399) #404

Merged

Conversation

larrytamnjong
Copy link
Contributor

No description provided.

@larrytamnjong larrytamnjong marked this pull request as ready for review December 3, 2024 06:52
var req = await _client.Connect.CAGetConfig();
var result = req.Response;

Assert.Equal("consul", result.Provider);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test all other fields too.

@larrytamnjong
Copy link
Contributor Author

Hi @marcin-krystianc please can you have another look and let me know if this is okay, thanks :)

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the test name, looks good otherwise.

Co-authored-by: Marcin Krystianc <[email protected]>
@marcin-krystianc marcin-krystianc merged commit 6b0e582 into G-Research:master Dec 20, 2024
243 checks passed
@larrytamnjong larrytamnjong deleted the get-ca-configuration branch December 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants