Added POST ConnectAuthorize endpoint, added test for the endpoint, method to IAgendEndpoint.cs #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod to IAgendEndpoint.cs
Consul/Interfaces/IAgentEndpoint.cs
Outdated
| @@ -63,6 +63,7 @@ public interface IAgentEndpoint | |||
| Task<QueryResult<LocalServiceHealth>> GetLocalServiceHealthByID(string serviceID, QueryOptions q, CancellationToken ct = default); | |||
| Task<QueryResult<LocalServiceHealth>> GetLocalServiceHealthByID(string serviceID, CancellationToken ct = default); | |||
| Task<QueryResult<Metrics>> GetAgentMetrics(CancellationToken ct = default); | |||
| Task<WriteResult<AgentAuthorizeResponse>> ConnectAuthorize(AgentAuthorizeParams parameters, CancellationToken ct = default); | |||
There was a problem hiding this comment.
We can also add an overload with query options.
There was a problem hiding this comment.
Oh yeah, that makes a lot of sense. Haven't seen that pattern in code with WriteResult so it didn't occur to me. Will implement.
There was a problem hiding this comment.
Ah, I didn't notice this is a write request, in this case we use WriteOptions instead of QueryOptions.
There was a problem hiding this comment.
Yep yep, that's what I thought. Just pushed the commit, waiting for the tests to run!
…overload to ConnectAuthorize to support WriteOptions
marcin-krystianc
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #341