Basic Connect support for service registration on the agent #216
Conversation
Added properties. AgentServiceRegistration class: Added properties. Added classes: AgentServiceConnect, AgentServiceProxy. Added tests.
Consul/Agent.cs
Outdated
| } | ||
|
|
||
| /// <summary> | ||
| /// AgentServiceProxy specifies the configuration for a Connect service proxy instance.This is only valid if Kind defines a proxy or gateway |
There was a problem hiding this comment.
nit: extra space needed after .
| @@ -139,6 +139,9 @@ public class AgentService | |||
| public IDictionary<string, ServiceTaggedAddress> TaggedAddresses { get; set; } | |||
| public bool EnableTagOverride { get; set; } | |||
| public IDictionary<string, string> Meta { get; set; } | |||
|
|
|||
| [JsonProperty(NullValueHandling = NullValueHandling.Ignore)] // If the Proxy property is serialized to have null value, a protocol error occurs when registering the service through the catalog (catalog/register) during an http request. | |||
| public AgentServiceProxy Proxy { get; set; } | |||
There was a problem hiding this comment.
While this seems to work fine without, maybe for clarity, it would be good to add the Kind property https://developer.hashicorp.com/consul/api-docs/agent/service
Kind (string: "") - The kind of service. Defaults to "" which is a typical Consul service. This value may also be "connect-proxy" for Connect proxies representing another service, "mesh-gateway" for instances of a mesh gateway, "terminating-gateway" for instances of a terminating gateway, or "ingress-gateway" for instances of a ingress gateway.
There was a problem hiding this comment.
Hi. I added a Kind property of type ServiceKind.
Add Tests
Consul/Agent.cs
Outdated
| public static ServiceKind TerminatingGateway => Map["terminating-gateway"]; | ||
| public static ServiceKind IngressGateway => Map["ingress-gateway"]; | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: Unnecessary extra new lines.
Consul/Agent.cs
Outdated
|
|
||
| string Value { get; } | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: Unnecessary extra new lines.
Consul/Agent.cs
Outdated
|
|
||
| ServiceKind(string value) => Value = value; | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: Unnecessary extra new lines.
Consul.Test/ServiceKindUnitTests.cs
Outdated
| new object[] { "Ingress-gateway", true, ServiceKind.IngressGateway }, | ||
| }; | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: Unnecessary extra new lines.
Added basic Consul Connect support when registering service on agent.
https://developer.hashicorp.com/consul/docs/connect/registration/sidecar-service