Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Agent_Register_UseAliasCheck test more robust #203

Merged
merged 42 commits into from
Mar 20, 2023
Merged

Make the Agent_Register_UseAliasCheck test more robust #203

merged 42 commits into from
Mar 20, 2023

Conversation

marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Mar 14, 2023 •
edited
Loading

Fixes flakiness of the Agent_Register_UseAliasCheck test.
It is still more of a guesswork, but I've tried 5 times (see statuses for last 5 commits), and the only failed check is not related to the Agent_Register_UseAliasCheck`.

@marcin-krystianc marcin-krystianc force-pushed the dev-marcink-20230314-UseAliasCheck branch from 3e6950e to ce63fa7 Compare March 17, 2023 21:14
marcin-krystianc
marcin-krystianc commented Mar 17, 2023
View reviewed changes
Consul.AspNetCore.Test/Consul.AspNetCore.Test.csproj
@@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<CheckEolTargetFramework>false</CheckEolTargetFramework>
Copy link
Contributor Author

@marcin-krystianc marcin-krystianc Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes warnings about net5.0 being out of support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, maybe we should remove these 2 unsupported targets at some point.

@marcin-krystianc marcin-krystianc changed the title Make Agent_Register_UseAliasCheck more robust Make the Agent_Register_UseAliasCheck test more robust Mar 17, 2023
@marcin-krystianc marcin-krystianc marked this pull request as ready for review March 18, 2023 14:32
@marcin-krystianc marcin-krystianc requested a review from mfkl March 18, 2023 14:32
@mfkl
Copy link
Contributor

mfkl commented Mar 20, 2023

I guess these need fixing/more delay too in a follow up PR?

[xUnit.net 00:00:40.12]     Consul.Test.LockTest.Lock_ContendFast [FAIL]
[xUnit.net 00:00:40.16]     Consul.Test.SemaphoreTest.Semaphore_ContendFast [FAIL]
Error: Consul.Test.LockTest.Lock_ContendFast: Consul.ConsulRequestException : Unexpected response, status code InternalServerError: raft apply failed: invalid session "f23ba675-63ba-7d7f-e78a-089edece68f8"
  Failed Consul.Test.LockTest.Lock_ContendFast [33 s]
  Error Message:
   Consul.ConsulRequestException : Unexpected response, status code InternalServerError: raft apply failed: invalid session "f23ba675-63ba-7d7f-e78a-089edece68f8"
  Stack Trace:
    at Consul.PutRequest`2[TIn,TOut].Execute (System.Threading.CancellationToken ct) [0x002c0] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Lock.Acquire (System.Threading.CancellationToken ct) [0x00447] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Lock.Acquire (System.Threading.CancellationToken ct) [0x00797] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Test.LockTest+<>c__DisplayClass9_1.<Lock_ContendFast>b__0 () [0x00096] in <8414f090076d467489b2f13a4b8c691d>:0 
  at Consul.Test.TimeoutUtils.WithTimeout (System.Threading.Tasks.Task task) [0x000fe] in <8414f090076d467489b2f13a4b8c691d>:0 
  at Consul.Test.LockTest.Lock_ContendFast () [0x000d8] in <8414f090076d467489b2f13a4b8c691d>:0 
Error: Consul.Test.SemaphoreTest.Semaphore_ContendFast: Consul.ConsulRequestException : Unexpected response, status code InternalServerError: raft apply failed: invalid session "b6e208d2-1a95-d550-d70d-94b256257be4"
  Failed Consul.Test.SemaphoreTest.Semaphore_ContendFast [30 s]
  Error Message:
   Consul.ConsulRequestException : Unexpected response, status code InternalServerError: raft apply failed: invalid session "b6e208d2-1a95-d550-d70d-94b256257be4"
  Stack Trace:
    at Consul.PutRequest`2[TIn,TOut].Execute (System.Threading.CancellationToken ct) [0x002c0] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Semaphore.Acquire (System.Threading.CancellationToken ct) [0x00261] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Semaphore.Acquire (System.Threading.CancellationToken ct) [0x007a1] in <5e8fd460af7840daaa934f30b8287984>:0 
  at Consul.Test.SemaphoreTest+<>c__DisplayClass9_1.<Semaphore_ContendFast>b__0 () [0x00097] in <8414f090076d467489b2f13a4b8c691d>:0 
  at Consul.Test.TimeoutUtils.WithTimeout (System.Threading.Tasks.Task task) [0x000fe] in <8414f090076d467489b2f13a4b8c691d>:0 
  at Consul.Test.SemaphoreTest.Semaphore_ContendFast () [0x000d8] in <8414f090076d467489b2f13a4b8c691d>:0

@marcin-krystianc
Copy link
Contributor Author

I guess these need fixing/more delay too in a follow up PR?

Yes, these happened few time as well, but it is definitely a problem for another PR.

@marcin-krystianc marcin-krystianc merged commit dcb7cce into G-Research:master Mar 20, 2023
@marcin-krystianc marcin-krystianc deleted the dev-marcink-20230314-UseAliasCheck branch March 20, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfkl mfkl mfkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcin-krystianc @mfkl