CI: use enterprise build

[mfkl]

To use a consul enterprise version, 2 things are needed:

• An enterprise build (addressed by this PR),
• The consul enterprise key as an environment variable https://developer.hashicorp.com/nomad/tutorials/enterprise/hashicorp-enterprise-license. Someone with the necessary github rights will be able to do so.

I have tested the starting the enterprise agent locally.

[mfkl]

This is not the most elegant, but it does the job. What do you guys think?

Consul Enterprise APIs, when called on the community edition server naturally return HTTP 404.

With a XUnit SkippableFact, we can implement tests for these Enterprise version-only APIs and they can be skipped by adding this 2 line check in the beginning of any of these tests when the server is not Enterprise.

[marcin-krystianc]

Another possibility is to implement custom Fact attribute, e.g.:

    public class EnterpriseOnlyFactAttribute : FactAttribute
    {
        public EnterpriseOnlyFactAttribute()
        {
            if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable("RUN_CONSUL_ENTERPRISE_TESTS")))
            {
                Skip = "Ignored non-0enterprise servers";
            }
        }
    }

And the use:

[EnterpriseOnlyFactAttribute]
public async Task Operator_GetLicense()
{
    var license = await _client.Operator.GetConsulLicense();
    ...
}

It lets us to skip enterprise-only facts without making any extra http requests. 
Also, it feels more elegant in my opinion.

[mfkl]

Much better, thanks!

[marcin-krystianc]

I think it would be good to use enterprise version for PR branches and for master branch. Without running the enterprise version on branches, it is going to be a huge struggle to test changes relevant for enterprise version.

[mfkl]

please remember that the secret is not passed to workflows that are triggered by a pull request from a fork

Ok, I think the github secret (e.g. enterprise license) will need some changes too :-) @jgiannuzzi

[marcin-krystianc]

Can't we just run the enterprise tests when the workflow is not triggered from a fork (regardless of the branch it is triggered from?).

[marcin-krystianc]

Another possibility is to implement custom Fact attribute, e.g.:

    public class EnterpriseOnlyFactAttribute : FactAttribute
    {
        public EnterpriseOnlyFactAttribute()
        {
            if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable("RUN_CONSUL_ENTERPRISE_TESTS")))
            {
                Skip = "Ignored non-0enterprise servers";
            }
        }
    }

And the use:

[EnterpriseOnlyFactAttribute]
public async Task Operator_GetLicense()
{
    var license = await _client.Operator.GetConsulLicense();
    ...
}

It lets us to skip enterprise-only facts without making any extra http requests. 
Also, it feels more elegant in my opinion.

[marcin-krystianc]

I think it would be good to add a comment explaining that this is enterprise-only feature

[marcin-krystianc]

Same here

[marcin-krystianc]

Can't we just run the enterprise tests when the workflow is not triggered from a fork (regardless of the branch it is triggered from?).

[marcin-krystianc]

Taking the liberty to merge and see whether the secret is correctly configured.