Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart for armada uses deprecated API, breaking install process #69

Open
andrewpcone opened this issue Mar 28, 2022 · 8 comments
Open

chart for armada uses deprecated API, breaking install process #69

andrewpcone opened this issue Mar 28, 2022 · 8 comments

Comments

@andrewpcone
Copy link

API extensions/v1beta1 was deprecated in Kubernetes v1.22, and replaced with networking.k8s.io/v1.

Installing Kubernetes from package management now typically yields higher versions (such as on Homebrew for Mac).

As a result, the line
helm install lookout gresearch/armada-lookout -f docs/quickstart/lookout-values.yaml
fails.

@jgiannuzzi
Copy link
Member

Thanks for reporting this @andrewpcone!

This should be fixed in the Armada repo itself. Let's keep this issue opened until it's fixed.

@andrewpcone
Copy link
Author

I don't understand. The charts live here, so it would seem this is where they need to be updated, no? What needs to change in the armada repo?

@andrewpcone
Copy link
Author

Ah, I see your comment on the PR. Understood.

@andrewpcone
Copy link
Author

The PR armadaproject/armada#901 corrects this issue. What is the correct way to generate updated .tgz files so that they can be committed here?

@jgiannuzzi
Copy link
Member

First your PR needs to be merged and part of a release, then depending on the status of #65 we may have to either manually create a PR to merge the branch created by the Armada CI, or it will all happen automatically (hopefully it's the latter!)

@andrewpcone
Copy link
Author

helm install armada-server gresearch/armada -f ./docs/quickstart/server-values.yaml still fails because of the outdated schema.
My PR to update the schema in the main repo got merged, but there's no new chart yet. What else needs to happn?

@JamesMurkin
Copy link
Contributor

My understanding is.

Assuming the release succeeded, it creates a branch on https://github.com/G-Research/charts with the update.

It then needs to have someone manually raise a PR with that branch + get it approved and merged. Ideal it would be totally automated but that isn't currently the case.

@andrewpcone
Copy link
Author

I don't follow: the PR with the schema change got merged into master in g-research/armada, and there have been subsequent releases since, so I'd have thought the new chart would show up. What else needs to happen now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants