Bump the SDK and stop building on <net8 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
previously approved these changes
Aug 20, 2024
Smaug123
commented
Aug 20, 2024
| @@ -21,11 +21,10 @@ | |||
| <ItemGroup> | |||
| <PackageReference Update="System.Text.Json" Version="8.0.4" /> | |||
| <PackageReference Include="FsCheck" Version="2.16.6" /> | |||
| <PackageReference Include="FSharp.Core" Version="4.3.4" /> | |||
There was a problem hiding this comment.
Deleted the unnecessary reference to an old FSharp.Core
|
This is now actually ready. |
nojaf
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/fsharp#16857 has changed the API surface. ApiSurface has the ability to discriminate surfaces between major versions of .NET, but not minor versions, so I just chose the simplest way of "assume everyone is running net8".