fix test warnings #543
Merged
fix test warnings #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
reviewed
Nov 7, 2024
| # Render matplotlib plots non-blocking | ||
| plt.ion() | ||
|
|
||
| def tearDown(self): | ||
| plt.close("all") | ||
| plt.ioff() | ||
| if Path.exists(Path("TEST_IMAGE")): | ||
| Path.unlink(Path(TEST_IMAGE)) | ||
| Path.unlink(Path(TEST_IMAGE), True) |
There was a problem hiding this comment.
Unrelated to this PR but should the line above be Path.exists(Path(TEST_IMAGE)) (instead of the string "TEST_IMAGE")?
nixio/util/util.py
Outdated
| @@ -97,7 +97,8 @@ def time_to_str(time): | |||
| :return: string in the form "YYYYMMDDTHHMMSS", where T is the date-time separator | |||
| :rtype: str | |||
| """ | |||
| dt = datetime.utcfromtimestamp(time) | |||
| # dt = datetime.utcfromtimestamp(time) | |||
There was a problem hiding this comment.
Any reason to keep the old line around as a comment? I think we can just delete it.
There was a problem hiding this comment.
a long time ago, it must have made sense ;) removed with the updated version
achilleas-k
approved these changes
Nov 8, 2024
|
Thanks, @achilleas-k ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
datetimedeprecation warnings.numpyversions > 2.0