Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy #542

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Numpy #542

merged 4 commits into from
Jul 9, 2024

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Jul 8, 2024

With numpy 2.0 we run into several issues. One is solved here, but there are more changes regarding string/unicode handling that kill the continuous integration at the moment. Most of them I could not reproduce locally. As an intermediate solution I limited numpy to versions less than 2.0.

This pr fixes:

  • miniconda action by specifying the version to "latest"
  • switches to pathlib instead of os in test_docs
  • load_module deprecation

@achilleas-k if you could spare a quick look ;)

@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

coverage: 79.774% (-0.008%) from 79.782%
when pulling 34c4f49 on jgrewe:numpy
into a89d844 on G-Node:master.

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@achilleas-k achilleas-k merged commit 915a232 into G-Node:master Jul 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants