Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create exceptions specific to 3scale-cms and standardize exception handling #16

Closed
rmgrimm opened this issue Nov 14, 2022 · 0 comments · Fixed by #100
Closed

Create exceptions specific to 3scale-cms and standardize exception handling #16

rmgrimm opened this issue Nov 14, 2022 · 0 comments · Fixed by #100
Labels
enhancement New feature or request

Comments

@rmgrimm
Copy link
Contributor

rmgrimm commented Nov 14, 2022

Currently, the 3scale-cms code makes use of generic exceptions. In order to provide clarity and better description of the exceptional cases, as well as facilitating programmatic handling of the exceptions, the 3scale-cms client code should implement new exceptions. 3scale CMS exceptions should each descend (directly or indirectly) from RuntimeException

For example, when client code that's generated from the OpenAPI spec throws ApiException, the exception should be interrogated for information to use with throwing a new 3scale-cms-specific exception.
@rmgrimm rmgrimm added the enhancement New feature or request label Nov 14, 2022
rmgrimm added a commit to rmgrimm/3scale-cms that referenced this issue Nov 8, 2023
@rmgrimm
Fix uploads; add exception classes; other fixes
cf5b30f 
* Do not send empty layout ("") for new pages
* Use application/x-www-form-urlencoded for template create requests
* Do not handle tag_list on files as it's not part of the API anymore
* Add an Exception hierarchy
* Refer to the API using its official name Developer Portal API instead of Content Management API
* Remove distinction between ErrorHash and plain Error objects in OpenAPI doc

Resolves FwMotion#99
Resolves FwMotion#16
@rmgrimm rmgrimm mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix uploads; add exception classes; other fixes rmgrimm/3scale-cms
1 participant
@rmgrimm