Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit tenant core concepts #3488

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Audit tenant core concepts #3488

wants to merge 16 commits into from

Conversation

mooreds
Copy link
Contributor

@mooreds mooreds commented Jan 29, 2025 •
edited
Loading

Included image updates, cutting off versions on some images (to future proof them), some nav rework and more.

Should merge

first, as I peeled off the first two commits of this PR for easier review.

mooreds added 10 commits January 28, 2025 16:58
@mooreds
updated to reflect that FQDN should include prefix for OIDC compliance.
eb06788 
https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata says

the issuer is 'REQUIRED. URL using the https scheme with no query or fragment components that the OP asserts as its Issuer Identifier. If Issuer discovery is supported (see Section 2), this value MUST be identical to the issuer value returned by WebFinger. This also MUST be identical to the iss Claim value in ID Tokens issued from this Issuer. '
@mooreds
added debug enabled field
e399a7e
@mooreds
updated webauthn for community plan
56b404d
@mooreds
moved webauthn to proper location
d9c33d6
@mooreds
reworked headings so that we have each of the tenant tabs in the top …
aa206db 
…level right nav
@mooreds
more details about password hashes
bfebdca
@mooreds
clarifying wording
f7f8639
@mooreds
move connector policy doc to under connectors section
98b1b35
@mooreds
updated screenshots
26a3f58
@mooreds
cropping images as needed
cb7bcef
@mooreds mooreds requested review from a team as code owners January 29, 2025 18:07
This was referenced Jan 29, 2025
Merged
Merged
@mooreds mooreds requested review from synedra and removed request for synedra January 29, 2025 20:42
dcharles8
dcharles8 reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@dcharles8 dcharles8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look good to me. Not something you introduced, but I noticed that the screenshots in the WebAuthn section don't adhere to our screenshot standards. They look a bit off compared to the rest of the page.

@mooreds
Copy link
Contributor Author

mooreds commented Feb 1, 2025

@dcharles8 I screenshotted the webauthn section as well.

Please review and approve if it makes sense.

Thanks!

@mooreds mooreds requested a review from dcharles8 February 3, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcharles8 dcharles8 Awaiting requested review from dcharles8

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mooreds @dcharles8