Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change ScrollRef components to Anchor links #3456

Merged
merged 15 commits into from
Feb 10, 2025

Conversation

sixhobbits
Copy link
Collaborator

removing ScrollRef from frontegg article and everywhere else, see:

FusionAuth/fusionauth-issues#2946

@sixhobbits sixhobbits requested review from a team as code owners January 8, 2025 13:37
@sixhobbits sixhobbits changed the title Change scrollref markdown links docs: Change ScrollRef components to Anchor links Jan 8, 2025
@bradmccarty bradmccarty self-assigned this Jan 22, 2025
bradmccarty
bradmccarty previously approved these changes Jan 22, 2025
Copy link
Contributor

@bradmccarty bradmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to have @mooreds or @mark-robustelli peek at the failing API checks.

@bradmccarty bradmccarty dismissed their stale review January 22, 2025 19:30

Going to have Dan or Mark peek at the check_apis failutres.

@bradmccarty
Copy link
Contributor

@mooreds or @mark-robustelli I think the api checks are outside of my realm of knowledge. Could one of y'all take a peek and handle the approval if they're not of concern?

@mark-robustelli
Copy link
Contributor

@sixhobbits Looks like the api check is failing. Can you please update so the check pass?

opening: /home/runner/work/fusionauth-site/fusionauth-site/fusionauth-client-builder/src/main/domain/io.fusionauth.domain.event.UserUpdateEvent.json
processing userUpdateEvent
retrieving https://fusionauth.io/docs/extend/events-and-webhooks/events/user-update
not traversing event.original, but checking if it is in the content of extend/events-and-webhooks/events/user-update
not traversing event.user, but checking if it is in the content of extend/events-and-webhooks/events/user-update
MISSING FIELDS
{:original_examined_type=>"application.jwtConfiguration.refreshTokenRevocationPolicy", :full_field_name=>"application.jwtConfiguration.refreshTokenRevocationPolicy.onOneTimeTokenReuse", :type=>"boolean"}

@sixhobbits
Copy link
Collaborator Author

@mark-robustelli - we've fixed most of them, then that will leave only this one

Failed Check about br tags
/home/runner/work/fusionauth-site/fusionauth-site/astro/src/content/docs/lifecycle/authenticate-users/oauth/endpoints.mdx
435:145 error Unexpected HTML tag [br], use markdown instead remark-lint-no-html
435:211 error Unexpected HTML tag [br], use markdown instead remark-lint-no-html
435:305 error Unexpected HTML tag [br], use markdown instead remark-lint-no-html
435:394 error Unexpected HTML tag [br], use markdown instead remark-lint-no-html

That's about this table where a bullet list is used inside a table cell.

image

Because you can't use newlines in a table (it would create new rows), using
s is the only easy way to get this layout

Any suggestions on how to handle this? Should we reword that table, or can we bypass the check for this?

Current table code is

-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 302  | The request was successful and the redirect location will be determined by using the configuration values in the following precedence: <br/>* The `post_logout_redirect_uri` request parameter if present<br/>* The <InlineField>logoutURL</InlineField> defined in the Application OAuth configuration<br/>* The <InlineField>logoutURL</InlineField> defined in the Tenant OAuth configuration<br/>* `/` |
| 400  | The request was invalid and/or malformed. The response will contain a JSON message with the specific errors. The error response JSON is covered in the [OAuth Error section](#oautherror) of the API documentation.

@mooreds
Copy link
Contributor

mooreds commented Feb 5, 2025

You can bypass checks with

{/* eslint-disable-line */}

Mark is closer to the PR so I'll let him weigh in on what the right path forward is.

@mark-robustelli
Copy link
Contributor

I think we are good with bypassing for this.

@bradmccarty bradmccarty merged commit 9f652fd into FusionAuth:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants