Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seek-to-timestamp #376

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix seek-to-timestamp #376

merged 1 commit into from
Aug 15, 2024

Conversation

marcoccchan
Copy link
Contributor

@marcoccchan marcoccchan commented Aug 12, 2024

This fixes #371 — thanks to @djeis97 for spotting.

- if the specified timestamp exceeds that of any previously written message
then the consumer offset should be set to .endOffsets

- incrementing .endOffsets by one will cause a message to missed
@marcoccchan marcoccchan requested a review from a team as a code owner August 12, 2024 15:57
@fc-infosec-sast
Copy link

✅ Coberos SAST Report

No issues found. Good job! 💪

@marcoccchan marcoccchan merged commit bc35601 into master Aug 15, 2024
7 checks passed
@marcoccchan marcoccchan deleted the mc-fix-seek-to-timestamp branch August 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seek to timestamp possibly off by one
3 participants