-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Kafka 2.4.1 #270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 41 41
Lines 2586 2586
Branches 153 153
=======================================
Hits 2099 2099
Misses 334 334
Partials 153 153 Continue to review full report at Codecov.
|
Kafka 2.4 is providing new partition assignment strategies such as cooperative-sticky |
Might be worth also updating the images used by CI to the corresponding confluent release. https://github.com/FundingCircle/jackdaw/blob/master/.circleci/config.yml#L44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the review. |
I'm no longer an administrator so dunno when someone will be able to get a release out. If you have a pressing need though, you may be able to just override the kafka dependencies in your own project.clj. |
Any update on this, any administrators able to get a release out? |
Following ... we could use the new support for |
fyi, I have merged a few PRs that I needed (including this one) in my fork. I don't really want to maintain this fork or make something official |
Closing since we upgraded to 2.8.0 via #292 |
Checklist