[lint] Remove unused bindings

Only left the more tricky ones which will be tackled in a later commit

src/jackdaw/admin.clj

@@ -158,7 +158,7 @@
   {:pre [(client? client)
          (sequential? topics)]}
   (->> @(describe-topics* client (map :topic-name topics))
-       (every? (fn [[topic-name {:keys [partition-info]}]]
+       (every? (fn [[_topic-name {:keys [partition-info]}]]
                  (every? (fn [part-info]
                            (and (boolean (:leader part-info))
                                 (seq (:isr part-info))))

src/jackdaw/client.clj

@@ -46,7 +46,7 @@
   Callbacks are `void`, so the return value is ignored."
   ^Callback [on-completion]
   (reify Callback
-    (onCompletion [this record-meta exception]
+    (onCompletion [_this record-meta exception]
       (on-completion record-meta exception))))
 
 (defn send!

src/jackdaw/client/partitioning.clj

@@ -64,7 +64,7 @@
 
 (defn default-partition
   "The kafka default partitioner. As a `::partition-fn`"
-  [{:keys [topic-name key-serde]} key value partitions]
+  [{:keys [topic-name key-serde]} key _value partitions]
   (let [key-bytes (.serialize (.serializer ^Serde key-serde) topic-name key)]
     (default-partitioner* key-bytes partitions)))
 
@@ -92,11 +92,11 @@
        (partition-fn t key value %)
        (->ProducerRecord producer t % key value))
      (jd/->ProducerRecord t key value)))
-  ([^Producer producer topic partition key value]
+  ([^Producer _producer topic partition key value]
    (jd/->ProducerRecord topic (int partition) key value))
-  ([^Producer producer topic partition timestamp key value]
+  ([^Producer _producer topic partition timestamp key value]
    (jd/->ProducerRecord topic partition  timestamp key value))
-  ([^Producer producer topic partition timestamp key value headers]
+  ([^Producer _producer topic partition timestamp key value headers]
    (jd/->ProducerRecord topic partition timestamp key value headers)))
 
 (defn produce!
@@ -108,15 +108,15 @@
   ([producer topic value]
    (jc/send! producer
              (->ProducerRecord producer topic value)))
-  ([producer topic key value]
+  ([producer topic _key value]
    (jc/send! producer
              (->ProducerRecord producer topic value)))
-  ([producer topic partition key value]
+  ([producer topic partition _key value]
    (jc/send! producer
              (->ProducerRecord producer topic partition topic value)))
-  ([producer topic partition timestamp key value]
+  ([producer topic partition timestamp _key value]
    (jc/send! producer
              (->ProducerRecord producer topic partition timestamp topic value)))
-  ([producer topic partition timestamp key value headers]
+  ([producer topic partition timestamp _key value headers]
    (jc/send! producer
              (->ProducerRecord producer topic partition timestamp topic value headers))))

src/jackdaw/data/common.clj

@@ -44,12 +44,10 @@
   (TopicPartition. topic-name (int partition)))
 
 (defn map->TopicPartition
-  "Given a `::topic-parititon`, build an equivalent `TopicPartition`.
+  "Given a `topic-partition`, build an equivalent `TopicPartition`.
 
   Inverts `(datafy ^TopicPartition tp)`."
-  [{:keys [topic-name
-           partition]
-    :as m}]
+  [{:keys [partition] :as m}]
   (->TopicPartition m partition))
 
 (defn->data TopicPartition->data [^TopicPartition tp]

src/jackdaw/data/consumer.clj

@@ -81,8 +81,7 @@
   {:offset (.offset ots)
    :timestamp (.timestamp ots)})
 
-(defn map->OffsetAndTimestamp
-  [{:keys [offset timestamp] :as m}]
+(defn map->OffsetAndTimestamp [m]
   (->OffsetAndTimestamp m))
 
 (defn as-OffsetAndTimestamp

src/jackdaw/data/producer.clj

@@ -82,14 +82,14 @@
   required. The third arity allows a user to provide a checksum. This
   arity may be removed in the future pending further breaking changes
   to the Kafka APIs."
-  ([{:keys [:topic-name] :as t} partition offset timestamp key-size value-size]
+  ([t partition offset timestamp key-size value-size]
    (RecordMetadata. (->TopicPartition t partition)
                     offset 0 ;; Force absolute offset
                     timestamp
                     nil ;; No checksum, it's deprecated
                     ^Integer (when key-size (int key-size))
                     ^Integer (when value-size (int value-size))))
-  ([{:keys [:topic-name] :as t} partition base-offset relative-offset timestamp
+  ([t partition base-offset relative-offset timestamp
     key-size value-size]
    (RecordMetadata. (->TopicPartition t partition)
                     base-offset
@@ -98,7 +98,7 @@
                     nil ;; No checksum, it's depreciated
                     ^Integer (when key-size (int key-size))
                     ^Integer (when value-size (int value-size))))
-  ([{:keys [:topic-name] :as t} partition base-offset relative-offset timestamp checksum
+  ([t partition base-offset relative-offset timestamp checksum
     key-size value-size]
    (RecordMetadata. (->TopicPartition t partition)
                     base-offset

src/jackdaw/serdes/avro.clj

@@ -198,7 +198,7 @@
   (try
     (and (number? x)
          (coercion-fn (bigint x)))
-    (catch RuntimeException e
+    (catch RuntimeException _e
       false)))
 
 (defrecord DoubleType []
@@ -260,12 +260,14 @@
 
 (defrecord SchemalessType []
   SchemaCoercion
-  (match-clj? [_ x]
+  (match-clj? [_schema-type _clj-data]
     true)
-  (match-avro? [_ x]
+  (match-avro? [_schema-type _avro-data]
     true)
-  (avro->clj [_ x] x)
-  (clj->avro [_ x path] x))
+  (avro->clj [_schema-type avro-data]
+    avro-data)
+  (clj->avro [_schema-type clj-data _path]
+    clj-data))
 
 ;; UUID :disapprove:
 
@@ -278,7 +280,7 @@
   (avro->clj [_ uuid-utf8]
     (try
       (UUID/fromString (str uuid-utf8))
-      (catch Exception e
+      (catch Exception _e
         (str uuid-utf8))))
   (clj->avro [this uuid path]
     (validate-clj! this uuid path "uuid")
@@ -639,17 +641,14 @@
         (get @coercion-cache avro-schema)))))
 
 (defn- coercion-type
-  [avro-schema {:keys [type-registry
-                       coercion-cache] :as coercion-stack}]
+  [avro-schema coercion-stack]
   ((schema->coercion coercion-stack) avro-schema))
 
 (defn as-json
   "Returns the json representation of the supplied `edn+avro`
 
    `edn+avro` is an avro object represented as an edn object (compatible with the jackdaw avro serde)"
-  [{:keys [type-registry
-           avro-schema
-           coercion-cache] :as coercion-stack} edn+avro]
+  [{:keys [avro-schema] :as coercion-stack} edn+avro]
   (let [schema (parse-schema-str avro-schema)
         record (clj->avro (coercion-type schema coercion-stack) edn+avro [])
         out-stream (ByteArrayOutputStream.)
@@ -665,9 +664,7 @@
   "Returns the edn representation of the supplied `json+avro`
 
    `json+avro` is an avro object represented as a json string"
-  [{:keys [type-registry
-           coercion-cache
-           avro-schema] :as coercion-stack} json+avro]
+  [{:keys [avro-schema] :as coercion-stack} json+avro]
   (let [schema (parse-schema-str avro-schema)
         decoder (.jsonDecoder ^DecoderFactory (DecoderFactory.)
                               ^Schema schema

src/jackdaw/streams/extras.clj

@@ -46,15 +46,15 @@
 
       (^void onBatchRestored [_
                               ^TopicPartition topicPartition
-                              ^String storeName
-                              ^long batchEndOffset
-                              ^long numRestored]
+                              ^String _storeName
+                              ^long _batchEndOffset
+                              ^long _numRestored]
        (log/warnf "Restored a batch from (%s.%d)"
                   (.topic topicPartition) (.partition topicPartition)))
       (^void onRestoreEnd [_
                            ^TopicPartition topicPartition
                            ^String storeName
-                           ^long totalRestored]
+                           ^long _totalRestored]
        (let [start-date  (get @restore-tracker storeName)
              elapsed-sec (.getSeconds (Duration/between start-date
                                                         (Instant/now)))]

src/jackdaw/streams/lambdas.clj

@@ -18,7 +18,7 @@
 
 (deftype FnAggregator [aggregator-fn]
   Aggregator
-  (apply [this agg-key value aggregate]
+  (apply [_this agg-key value aggregate]
     (aggregator-fn aggregate [agg-key value])))
 
 (defn aggregator
@@ -28,7 +28,7 @@
 
 (deftype FnForeachAction [foreach-action-fn]
   ForeachAction
-  (apply [this key value]
+  (apply [_this key value]
     (foreach-action-fn [key value])
     nil))
 
@@ -39,7 +39,7 @@
 
 (deftype FnInitializer [initializer-fn]
   Initializer
-  (apply [this]
+  (apply [_this]
     (initializer-fn)))
 
 (defn initializer
@@ -49,7 +49,7 @@
 
 (deftype FnKeyValueMapper [key-value-mapper-fn]
   KeyValueMapper
-  (apply [this key value]
+  (apply [_this key value]
     (key-value (key-value-mapper-fn [key value]))))
 
 (defn key-value-mapper
@@ -59,7 +59,7 @@
 
 (deftype FnSelectKeyValueMapper [select-key-value-mapper-fn]
   KeyValueMapper
-  (apply [this key value]
+  (apply [_this key value]
     (select-key-value-mapper-fn [key value])))
 
 (defn select-key-value-mapper
@@ -70,7 +70,7 @@
 
 (deftype FnKeyValueFlatMapper [key-value-flatmapper-fn]
   KeyValueMapper
-  (apply [this key value]
+  (apply [_this key value]
     (mapv key-value (key-value-flatmapper-fn [key value]))))
 
 (defn key-value-flatmapper
@@ -83,7 +83,7 @@
 
 (deftype FnMerger [merger-fn]
   Merger
-  (apply [this agg-key aggregate1 aggregate2]
+  (apply [_this agg-key aggregate1 aggregate2]
     (merger-fn agg-key aggregate1 aggregate2)))
 
 (defn merger
@@ -93,7 +93,7 @@
 
 (deftype FnPredicate [predicate-fn]
   Predicate
-  (test [this key value]
+  (test [_this key value]
     (boolean (predicate-fn [key value]))))
 
 (defn predicate
@@ -103,7 +103,7 @@
 
 (deftype FnReducer [reducer-fn]
   Reducer
-  (apply [this value1 value2]
+  (apply [_this value1 value2]
     (reducer-fn value1 value2)))
 
 (defn reducer
@@ -113,7 +113,7 @@
 
 (deftype FnValueJoiner [value-joiner-fn]
   ValueJoiner
-  (apply [this value1 value2]
+  (apply [_this value1 value2]
     (value-joiner-fn value1 value2)))
 
 (defn value-joiner
@@ -123,7 +123,7 @@
 
 (deftype FnValueMapper [value-mapper-fn]
   ValueMapper
-  (apply [this value]
+  (apply [_this value]
     (value-mapper-fn value)))
 
 (defn value-mapper
@@ -133,7 +133,7 @@
 
 (deftype FnStreamPartitioner [stream-partitioner-fn]
   StreamPartitioner
-  (partition [this topic-name key val partition-count]
+  (partition [_this topic-name key val partition-count]
     (stream-partitioner-fn topic-name key val partition-count)))
 
 (defn stream-partitioner
@@ -157,7 +157,7 @@
 
 (deftype FnProcessorSupplier [processor-supplier-fn]
   ProcessorSupplier
-  (get [this]
+  (get [_this]
     (processor processor-supplier-fn)))
 
 (defn processor-supplier
@@ -167,7 +167,7 @@
 
 (deftype FnTransformerSupplier [transformer-supplier-fn]
   TransformerSupplier
-  (get [this]
+  (get [_this]
     (transformer-supplier-fn)))
 
 (defn transformer-supplier
@@ -177,7 +177,7 @@
 
 (deftype FnValueTransformerSupplier [value-transformer-supplier-fn]
   ValueTransformerSupplier
-  (get [this]
+  (get [_this]
     (value-transformer-supplier-fn)))
 
 (defn value-transformer-supplier
@@ -187,10 +187,10 @@
 
 (deftype FnTransformer [context xfm-fn]
   Transformer
-  (init [this transformer-context]
+  (init [_this transformer-context]
     (reset! context transformer-context))
-  (close [this])
-  (transform [this k v]
+  (close [_this])
+  (transform [_this k v]
     (xfm-fn @context k v)))
 
 (defn transformer-with-ctx
@@ -211,10 +211,10 @@
 
 (deftype FnValueTransformer [context xfm-fn]
   ValueTransformer
-  (init [this transformer-context]
+  (init [_this transformer-context]
     (reset! context transformer-context))
-  (close [this])
-  (transform [this v]
+  (close [_this])
+  (transform [_this v]
     (xfm-fn @context v)))
 
 (defn value-transformer-with-ctx

src/jackdaw/test.clj

@@ -76,7 +76,7 @@
                         consumer
                         producer]
   java.io.Closeable
-  (close [this]
+  (close [_this]
     (doseq [hook exit-hooks]
       (hook))
     (log/info "destroyed test machine")))

src/jackdaw/test/commands/base.clj

@@ -7,13 +7,13 @@
 (def command-map
   {:stop (constantly true)
 
-   :sleep (fn [machine [sleep-ms]]
+   :sleep (fn [_machine [sleep-ms]]
             (Thread/sleep sleep-ms))
 
-   :println (fn [machine params]
+   :println (fn [_machine params]
               (println (apply str params)))
 
-   :pprint (fn [machine params]
+   :pprint (fn [_machine params]
               (pprint/pprint params))
 
    :do (fn [machine [do-fn]]

src/jackdaw/test/commands/write.clj

@@ -5,7 +5,7 @@
 
 (set! *warn-on-reflection* true)
 
-(defn default-partition-fn [topic-map topic-name k v partition-count]
+(defn default-partition-fn [topic-map _topic-name k _v partition-count]
   (int (partitioning/default-partition topic-map k nil partition-count)))
 
 (defn create-message [topic-map message opts]