Merge pull request #368 from FundingCircle/CAD-691-github-actions-mig…

…ration

[CAD-691] GitHub actions migration

.github/workflows/build.yaml

@@ -0,0 +1,9 @@
+run-name: Run Build
+
+on:
+  push
+
+jobs:
+  run_checks:
+    uses: ./.github/workflows/run_checks.yaml
+

.github/workflows/deploy.yaml

@@ -0,0 +1,35 @@
+run-name: Jackdaw build
+
+on:
+  push:
+    tags:
+      - '[0-9]+.[0-9]+.[0-9]+'
+      - '*publish-snapshot*'
+
+jobs:
+  run_checks:
+    uses: ./.github/workflows/run_checks.yaml
+  deploy:
+    needs: run_checks
+    runs-on: ubuntu-latest
+    container: 
+      image: clojure:latest
+    environment: clojars_deploy
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4
+      - name: deploy
+        env:
+          CLOJARS_USERNAME: ${{ secrets.CLOJARS_USERNAME }}
+          CLOJARS_PASSWORD: ${{ secrets.CLOJARS_PASSWORD }}
+          GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
+        run: |
+          # https://github.com/actions/runner/issues/2033
+          git config --global --add safe.directory /__w/jackdaw/jackdaw
+          apt-get update
+          apt-get install -y gpg 
+          echo $GPG_PRIVATE_KEY |base64 --decode |gpg --yes --batch --import
+          export LEIN_GPG=/__w/jackdaw/jackdaw/bin/gpg
+          export REAL_GPG=$(which gpg)
+          lein do jar, pom, deploy clojars
+

.github/workflows/run_checks.yaml

@@ -0,0 +1,59 @@
+run-name: Run checks
+
+on:
+  workflow_call:
+
+jobs:
+  RunChecks:
+    runs-on: ubuntu-latest
+    container: 
+      image:  clojure:latest
+      options: --user 1001 # don't run as root
+    services:
+      kafka:
+        image: confluentinc/cp-kafka:5.1.3
+        env:
+          KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka:9092
+          KAFKA_AUTO_CREATE_TOPICS_ENABLE: true
+          KAFKA_BROKER_ID: 1
+          KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT
+          KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
+          KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
+          KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS: 0
+          KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
+          KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1
+      schema-registry:
+        image: confluentinc/cp-schema-registry:5.1.2
+        env:
+          SCHEMA_REGISTRY_HOST_NAME: schema-registry
+          SCHEMA_REGISTRY_KAFKASTORE_CONNECTION_URL: 'zookeeper:2181'
+      kafka-rest:
+        image: confluentinc/cp-kafka-rest:6.1.1
+        env:
+          KAFKA_REST_ZOOKEEPER_CONNECT: zookeeper:2181
+          KAFKA_REST_BOOTSTRAP_SERVERS: kafka:9092
+          KAFKA_REST_LISTENERS: http://0.0.0.0:8082
+          KAFKA_REST_SCHEMA_REGISTRY: http://schema-registry:8081
+          KAFKA_REST_HOST_NAME: kafka-rest
+      zookeeper:
+        image: confluentinc/cp-zookeeper:5.1.3
+        env: 
+          ZOOKEEPER_CLIENT_PORT: 2181
+          ZOOKEEPER_TICK_TIME: 2000
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4
+        with:
+          # do not fetch tags if the trigger event is a tag push
+          fetch-tags: ${{ startsWith(github.ref, 'refs/tags') != true }}
+          fetch-depth: 100
+      - name: build
+        run: | 
+          lein kaocha
+        env: 
+          KAFKA_BOOTSTRAP_SERVERS: kafka
+          ZOOKEEPER_HOST: zoopkeeper
+          SCHEMA_REGISTRY_HOST: schema-registry
+          KAFKA_REST_PROXY_HOST: kafka-rest
+      - name: lint
+        run: lein clj-kondo --lint src test || true

README.md

@@ -30,8 +30,12 @@ See [an example using jackdaw](https://github.com/FundingCircle/topology-grapher
 
 ## Releasing
 
-Anyone with the appropriate credentials can "cut a release" of jackdaw using the following steps.
+Anyone with the appropriate credentials can "cut a release" of jackdaw
+* Tags are protected, you will need to be a maintainer or admin to apply them
+* Clojars deployment uses a protected env, once a tag is created, the CI job to deploy will need to be reviewed by the clojars env owner
 
+
+Steps:
  1. Review the diff of master vs the latest released tag (e.g. while preparing 0.7.0, I looked at https://github.com/FundingCircle/jackdaw/compare/0.6.9...master to see what was actually merged vs what was in the Changelog). Make a PR to put a date on the version being released and if necessary ensure completeness and consistency of the Changelog
  2. Use the [Draft a new release](https://github.com/FundingCircle/jackdaw/releases/new) feature in github to prepare a release
  3. In the "tag version" field, enter the proposed version
@@ -42,6 +46,10 @@ Anyone with the appropriate credentials can "cut a release" of jackdaw using the
 
 Steps 2 to 6 is essentially `git tag $version -m "$title\n\n$description" && git push --tags`
 
+#### Snapshot release
+
+Snapshot releases can be created by pushing a tag with the format `publish-snapshot-semver`
+
 ## License
 
 Copyright © 2017 Funding Circle

.circleci/bin/gpg → bin/gpg

@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# Invoked by `LEIN_GPG=$app/.circleci/bin/gpg lein deploy clojars`
+# Invoked by `LEIN_GPG=$app/bin/gpg lein deploy clojars`
 
 echo $GPG_PASSPHRASE \
   | $REAL_GPG --pinentry-mode loopback --yes --batch --passphrase-fd=0 $@

project.clj

@@ -1,6 +1,8 @@
 (defproject fundingcircle/jackdaw "_"
   :description "A Clojure library for the Apache Kafka distributed streaming platform."
 
+  :license {:name "BSD 3-clause"  :url "http://opensource.org/licenses/BSD-3-Clause"}
+
   :scm {:name "git" :url "https://github.com/fundingcircle/jackdaw"}
 
   :url "https://github.com/FundingCircle/jackdaw/"
@@ -33,12 +35,13 @@
 
   :aliases {"kaocha" ["run" "-m" "kaocha.runner"]}
   :aot [jackdaw.serdes.edn2 jackdaw.serdes.fressian jackdaw.serdes.fn-impl]
-  :plugins [[me.arrdem/lein-git-version "2.0.8"]]
+  :plugins [[me.arrdem/lein-git-version "2.0.8"]
+            [com.github.clj-kondo/lein-clj-kondo "0.2.5"]]
 
   :git-version
   {:status-to-version
    (fn [{:keys [tag branch ahead? dirty?] :as git}]
-     (if (and tag (not ahead?) (not dirty?))
+     (if (and tag (not ahead?) (not dirty?) (= "master" branch))
        tag
        (let [[_ prefix patch] (re-find #"(\d+\.\d+)\.(\d+)" tag)
              patch            (Long/parseLong patch)

test/jackdaw/client/partitioning_test.clj

@@ -2,7 +2,8 @@
   (:require
    [clojure.test :refer [deftest is testing]]
    [jackdaw.client :as client]
-   [jackdaw.client.partitioning :as part]))
+   [jackdaw.client.partitioning :as part]
+   [jackdaw.utils :as utils]))
 
 (set! *warn-on-reflection* false)
 
@@ -22,7 +23,7 @@
 
 
 (deftest test->ProducerRecord
-  (with-open [p (client/producer {"bootstrap.servers" "localhost:9092"
+  (with-open [p (client/producer {"bootstrap.servers" (utils/bootstrap-servers)
                                   "key.serializer" "org.apache.kafka.common.serialization.StringSerializer"
                                   "value.serializer" "org.apache.kafka.common.serialization.StringSerializer"})]
     (testing "absent key-fn"