Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable support for newer aws regions #214

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

bhanuvrat
Copy link
Contributor

@bhanuvrat bhanuvrat commented Feb 8, 2017

In order to setup s3 in mumbai region aka ap-south-1 as the static / media backend
the project would have to use storages.backends.s3boto3.S3Boto3Storage, which in
turn would need boto3 instead of boto and the newest version of django-storages.

django-storages-redux has not been updated since Jan 2016 and has been releasing on
pypi as django-storages since Feb 2016 when it became the official successor of the
repository it was a fork of[1].

[1] https://github.com/jschneier/django-storages#history
[2] jschneier/django-storages#28 (comment)

Why was this change necessary?

Trouble uploading to s3 in mumbai region

How does it address the problem?

adds required environment variables and upgrades boto3 and django-storages to their latest versions.

Are there any side effects?

Not in my knowledge.

In order to setup s3 in mumbai region aka ap-south-1 as the static / media backend
the project would have to use `storages.backends.s3boto3.S3Boto3Storage`, which in
turn would need boto3 instead of boto and the newest version of django-storages.

django-storages-redux has not been updated since Jan 2016 and has been releasing on
pypi as django-storages since Feb 2016 when it became the official successor of the
repository it was a fork of[1].

[1] https://github.com/jschneier/django-storages#history
@bhanuvrat bhanuvrat changed the title enable aws signature_version 4 for newer regions enable support for newer aws regions Feb 8, 2017
@karambir
Copy link
Contributor

Thanks @bhanuvrat

Looks Good. Even I wanted to go for boto3 asap 💯

@karambir karambir merged commit f6f9b9a into Fueled:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants