Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds generic trait impls to forc-doc #6850

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jan 22, 2025

Description

Closes #6848

Also adds the visibility keyword pub to public functions

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review January 22, 2025 02:00
@sdankel sdankel requested a review from a team as a code owner January 22, 2025 02:00
@sdankel sdankel requested a review from bitzoic January 22, 2025 02:01
@JoshuaBatty JoshuaBatty added the forc-doc Everything related to the `forc doc` command plugin. label Jan 22, 2025
@JoshuaBatty JoshuaBatty requested a review from a team January 22, 2025 02:09
@JoshuaBatty JoshuaBatty merged commit 9e1c320 into master Jan 22, 2025
39 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/doc-gen-impls branch January 22, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forc-doc Everything related to the `forc doc` command plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic impls missing from forc-doc
3 participants