Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover arrays of generics in JSON ABI by handling their type arguments #2303

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Cover arrays of generics in JSON ABI by handling their type arguments #2303

merged 5 commits into from
Jul 12, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Jul 12, 2022 •
edited
Loading

Just something I missed in #2218

@mohammadfawaz mohammadfawaz self-assigned this Jul 12, 2022
@mohammadfawaz mohammadfawaz added bug Something isn't working P: critical Should be looked at before anything else compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Jul 12, 2022
@mohammadfawaz mohammadfawaz requested review from a team and iqdecay July 12, 2022 00:30
@mohammadfawaz mohammadfawaz enabled auto-merge (squash) July 12, 2022 01:11
@mohammadfawaz mohammadfawaz requested a review from a team July 12, 2022 01:24
This was referenced Jul 12, 2022
Merged
Merged
adlerjohn
adlerjohn approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mohammadfawaz mohammadfawaz merged commit 441df3e into master Jul 12, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/arrays_of_generics_in_abi branch July 12, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@sezna sezna sezna approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@mohammadfawaz mohammadfawaz

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: critical Should be looked at before anything else
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohammadfawaz @adlerjohn @mitchmindtree @sezna