test: refactor StringCoder tests
#942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2023 16:49
…hub.com/FuelLabs/fuels-ts into db/test/refactor-string-coder-tests
|
|
danielbate
commented
May 2, 2023
Comment on lines
+73
to
+92
| // TODO: StringCoder should throw for these conditions? | ||
|
|
||
| // it('should throw when encoding a string that is too big', () => { | ||
| // const coder = new StringCoder(0); | ||
| // const invalidInput = STRING_MAX_DECODED; | ||
|
|
||
| // expect(() => { | ||
| // coder.encode(invalidInput); | ||
| // }).toThrow(); | ||
| // }); | ||
|
|
||
| // it('should throw when encoding a string that is too small', () => { | ||
| // const coder = new StringCoder(1); | ||
| // const invalidInput = STRING_MIN_DECODED; | ||
|
|
||
| // expect(() => { | ||
| // coder.encode(invalidInput); | ||
| // }).toThrow(); | ||
| // }); | ||
| }); |
There was a problem hiding this comment.
@FuelLabs/sdk-ts should we be throwing for these conditions? Other coders throw for this behaviour, wheras StringCoder will instead just slice the input by the length that is past to the construtor.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #753
This PR will:
encodeanddecode