test: increase coverage of PrivateKeyVault
#906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arboleya
requested review from
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
a team
Torres-ssf
previously approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Good stuff @danielbate 👍
I am just not completely sure about the changeset. I am under the impression that it needs to be empty for cases like this one. Is my impression correct, team @FuelLabs/sdk-ts ?
|
@Torres-ssf Precisely, we don't want to bump versions unless changes are introduced to the @danielbate You can empty the changeset manually: Example: |
arboleya
requested changes
Apr 18, 2023
Co-authored-by: Anderson Arboleya <[email protected]>
Torres-ssf
approved these changes
Apr 18, 2023
arboleya
approved these changes
Apr 18, 2023
camsjams
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #905
Add missing coverage of
getWallet()throw condition and update language style of test descriptions