-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjusting publish configs #902
Conversation
This PR is published in NPM with version 0.0.0-pr-902-20230416185541 |
Coverage report
Test suite run success777 tests passing in 114 suites. Report generated by 🧪jest coverage report action from 2051dab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Stuff 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this pr through pr-902
npm tag.
in wallet repo:
- build commands working
- dev commands working (
pnpm dev
,pnpm dev:crx
,pnpm dev:docs
)
in contract repo
- build commands working
- dev commands working
- no need to add polyfill anymore 👍🏻
issue that persists when running pnpm dev:crx
in wallet:
- chore: revamping build tooling #827 (comment)
I won't block this PR , but it's a blocker for wallet as we're stuck on an old version, without therefact: abi-coders
implementation
This PR:
typesVersions
configs, properly targeting:src/*.ts
files, when working locallydist/*.d.ts
files, after being published to NPM