Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjusting publish configs #902

Merged
merged 20 commits into from
Apr 17, 2023
Merged

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Apr 15, 2023

This PR:

  1. Adds individual typesVersions configs, properly targeting:
    • src/*.ts files, when working locally
    • dist/*.d.ts files, after being published to NPM
  2. Injects secondary entry points in main DTS files
    • Needed to provide full auto-import suggestions when installing from NPM

Note This is a fix on top of: #887 and #899.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2023

This PR is published in NPM with version 0.0.0-pr-902-20230416185541

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 95.01% 4643/4887
🟢 Branches 83.64% 823/984
🟢 Functions 92.32% 890/964
🟢 Lines 95.03% 4440/4672

Test suite run success

777 tests passing in 114 suites.

Report generated by 🧪jest coverage report action from 2051dab

@arboleya arboleya self-assigned this Apr 16, 2023
@arboleya arboleya marked this pull request as ready for review April 16, 2023 18:34
@arboleya arboleya closed this Apr 16, 2023
@arboleya arboleya reopened this Apr 16, 2023
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff 🚀

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this pr through pr-902 npm tag.

in wallet repo:

  • build commands working
  • dev commands working (pnpm dev, pnpm dev:crx, pnpm dev:docs)

in contract repo

  • build commands working
  • dev commands working
  • no need to add polyfill anymore 👍🏻

issue that persists when running pnpm dev:crx in wallet:

@arboleya arboleya merged commit 06f4d8b into master Apr 17, 2023
@arboleya arboleya deleted the aa/chore/adjusting-publish-configs branch April 17, 2023 19:36
@arboleya
Copy link
Member Author

The pnpm dev:crx issue happens only in #827, and has nothing to do with the master branch, or #891.

The #891 was already merged to master; why are you stuck on an old version without it?

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Apr 18, 2023

The pnpm dev:crx issue happens only in #827, and has nothing to do with the master branch, or #891.

The #891 was already merged to master; why are you stuck on an old version without it?

issue it's happening on master as well, if you want you can:

  • download wallet repo
  • test with next tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants