Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pagination for wallet getCoins getBalances #774

Closed

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added the feat Issue is a feature label Feb 9, 2023
@Torres-ssf Torres-ssf self-assigned this Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/home/runner/setup-pnpm/node_modules/.bin/pnpm' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements
94.04% (+1.37% 🔼)
4247/4516
🟢 Branches
80.49% (+1.7% 🔼)
751/933
🟢 Functions
90.8% (+0.87% 🔼)
839/924
🟢 Lines
93.91% (+1.4% 🔼)
4083/4348
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / script.ts
79.31% (-3.45% 🔻)
50% (-12.5% 🔻)
83.33%
79.31% (-3.45% 🔻)
🟢
... / errors.ts
100%
50% (-33.33% 🔻)
100% 100%
🟢 script/src/utils.ts
88.89% (-11.11% 🔻)
60% 100%
87.5% (-12.5% 🔻)
🟡
... / base-locked-wallet.ts
72.84% (-3.12% 🔻)
57.14% (-3.73% 🔻)
68.75%
72.84% (-3.12% 🔻)

Test suite run failed

Failed tests: 2/711. Failed suites: 2/97.
  ● CallTestContract › Test call with multiple arguments and different types -> add_ten

    Invalid Transaction status

      183 |       }
      184 |       default: {
    > 185 |         throw new Error('Invalid Transaction status');
          |               ^
      186 |       }
      187 |     }
      188 |   }

      at TransactionResponse.waitForResult (packages/providers/src/transaction-response/transaction-response.ts:185:15)
          at runMicrotasks (<anonymous>)
      at async Function.build (packages/contract/src/contracts/functions/invocation-results.ts:107:22)
      at async /home/runner/work/fuels-ts/fuels-ts/packages/fuel-gauge/src/call-test-contract.test.ts:152:25


  ● Contract Factory › Creates a factory from inputs that can return transaction results

    Invalid Transaction status

      183 |       }
      184 |       default: {
    > 185 |         throw new Error('Invalid Transaction status');
          |               ^
      186 |       }
      187 |     }
      188 |   }

      at TransactionResponse.waitForResult (packages/providers/src/transaction-response/transaction-response.ts:185:15)
          at runMicrotasks (<anonymous>)
      at async Function.build (packages/contract/src/contracts/functions/invocation-results.ts:107:22)
      at async Object.<anonymous> (packages/fuel-gauge/src/contract-factory.test.ts:61:35)

Report generated by 🧪jest coverage report action from 907fbc5

@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented Feb 22, 2023

Closing this for now since pagination for getBalances is not working as expected and was disabled on fuel-core.

@Torres-ssf Torres-ssf closed this Feb 22, 2023
@Torres-ssf Torres-ssf deleted the torres/feat/pagination-wallet-getCoins-getBalance branch February 26, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pagination on Wallet for getCoins / getBalances
1 participant