Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove call ops in tx summary #3734

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Feb 24, 2025

Summary

Removes some of the work introduced by #3704 but ensures the abiMap param still does not throw (#3703). #3710 proposed a way to introduce multi call operations, but the solution in #3733 is more robust. This PR sets the stage for #3733.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the chore Issue is a chore label Feb 24, 2025
@danielbate danielbate self-assigned this Feb 24, 2025
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 4:49pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 4:49pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 4:49pm

@petertonysmith94
Copy link
Contributor

We may want to remove the release notes from the original PR:

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.13%(-0.02%) 70.85%(+0.16%) 75.23%(-0.07%) 77.13%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/abi-coder/src/utils/scriptData.ts 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 packages/account/src/account.ts 81.03%
(+0.45%)
72%
(+0.77%)
82.5%
(+0%)
80.79%
(+0.45%)
🔴 packages/account/src/connectors/fuel-connector.ts 30%
(+1.43%)
100%
(+0%)
4.54%
(-0.22%)
30%
(+1.43%)
🔴 packages/account/src/connectors/fuel.ts 96.75%
(+0.02%)
90.66%
(+0%)
93.33%
(+0%)
96.87%
(+0.02%)
🔴 packages/account/src/providers/provider.ts 67.53%
(+0.58%)
59.8%
(+2.73%)
68.04%
(+0%)
67.29%
(+0.56%)
🔴 packages/account/src/providers/transaction-summary/call.ts 0%
(-6.25%)
0%
(+0%)
0%
(+0%)
0%
(-6.25%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 91.66%
(-0.34%)
88.88%
(+0%)
100%
(+0%)
91.66%
(-0.34%)

@danielbate danielbate merged commit da33ca5 into master Feb 24, 2025
26 checks passed
@danielbate danielbate deleted the db/chore/remove-call-ops-in-tx-summary branch February 24, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants