Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrading forc back to 0.48.1 #1680

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

arboleya
Copy link
Member

Forc 0.49.1 introduced some unplanned breaking changes that made life difficult.

I'm temporarily reverting it to 0.48.1 until everything is fixed.

@arboleya arboleya added the chore Issue is a chore label Jan 24, 2024
@arboleya arboleya added this to the 2 - Beetle milestone Jan 24, 2024
@arboleya arboleya self-assigned this Jan 24, 2024
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.91% 6159/7087
🟡 Branches 70.9% 965/1361
🟡 Functions 77.95% 1011/1297
🟢 Lines 86.89% 5903/6794

Test suite run success

1482 tests passing in 263 suites.

Report generated by 🧪jest coverage report action from c6412c4

@arboleya arboleya marked this pull request as ready for review January 24, 2024 10:09
@arboleya arboleya enabled auto-merge (squash) January 24, 2024 10:09
@arboleya arboleya merged commit 50bf779 into master Jan 24, 2024
9 of 12 checks passed
@arboleya arboleya deleted the aa/chore/revert-forc-upgrade branch January 24, 2024 10:13
@arboleya
Copy link
Member Author

I had to re-run the markdown-lint workflow 5 times, and it never worked.

Weirdly enough, the PR was merged when it got 2x approvals. 🤔

@arboleya arboleya mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants