feat: handle non-successful transaction statuses #1595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ns/feat/subscriptions
…transaction-status-receipts
…transaction-status-receipts
…le-non-successful-transaction-statuses
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
danielbate
as code owners
|
Closing because this is related to #1588 which needs to be fleshed out a bit more. The receipts should be properly decoded and be put into the error message. |
nedsalk
deleted the
ns/feat/handle-non-successful-transaction-statuses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1374 introduced subscriptions to transaction status changes, but it didn't handle the various states a transaction could change into. This PR introduces that.