refactor: remove hacky solution to get right witness offset #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate and
nedsalk
as code owners
Torres-ssf
changed the title
Torres-ssf
changed the title
danielbate
approved these changes
Dec 9, 2023
Torres-ssf
changed the title
Torres-ssf
changed the title
Coverage report
Test suite run success1465 tests passing in 258 suites. Report generated by 🧪jest coverage report action from 75f5b45 |
arboleya
approved these changes
Dec 11, 2023
Torres-ssf
deleted the
st/refactor/remove-hacky-solution-to-get-witness-offset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am removing a hacky solution that was originally added on PR #1307 to properly remove the witness bytes sizes from the TX bytes sizes when estimating the gas used on a TX.
This workaround was required because the witnesses's size calculations did not always match the same size that they were on the fuel-core side.
I have tried to simulate this error again after we update to
fuel-core0.21.0and it seems we do not have this issue anymore. So I am closing it.