Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite un-publish CI in JS #1490

Merged
merged 7 commits into from
Dec 10, 2023
Merged

fix: rewrite un-publish CI in JS #1490

merged 7 commits into from
Dec 10, 2023

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Dec 8, 2023

#1487 should have been written in JS as CI is failing as we only install node, not any other dependencies.

Closes #901

@danielbate danielbate self-assigned this Dec 8, 2023
@danielbate danielbate marked this pull request as ready for review December 8, 2023 13:44
@Torres-ssf Torres-ssf added the chore Issue is a chore label Dec 8, 2023
@danielbate danielbate enabled auto-merge (squash) December 8, 2023 13:59
@arboleya arboleya added this to the Salamander milestone Dec 8, 2023
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.54% 6025/6962
🟡 Branches 70.05% 933/1332
🟡 Functions 77.44% 992/1281
🟢 Lines 86.54% 5772/6670

Test suite run success

1465 tests passing in 258 suites.

Report generated by 🧪jest coverage report action from 9a80754

@danielbate danielbate merged commit 4ecd643 into master Dec 10, 2023
9 checks passed
@danielbate danielbate deleted the db/fix/unpublish-ci-js branch December 10, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Github Action to remove PR npm tags (if exists)
3 participants