Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve tx preparation for a Script and implement txId helper #1466

Merged
merged 7 commits into from
Nov 28, 2023
Merged

feat: improve tx preparation for a Script and implement txId helper #1466

merged 7 commits into from
Nov 28, 2023

Conversation

danielbate
Copy link
Member

Closes #1458

@danielbate danielbate self-assigned this Nov 27, 2023
@danielbate danielbate changed the title feat: document tx preparation for a Script and implement txId helper feat: imrove tx preparation for a Script and implement txId helper Nov 27, 2023
@danielbate danielbate marked this pull request as ready for review November 27, 2023 17:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
86.38% (-0.04% 🔻)
 5799/6713
🟡 Branches
70.02% (-0.11% 🔻)
 862/1231
🟡 Functions
77.09% (-0.06% 🔻)
 959/1244
🟢 Lines
86.36% (-0.04% 🔻)
 5551/6428

Test suite run success

1395 tests passing in 249 suites.

Report generated by 🧪jest coverage report action from 8bbe708

arboleya
arboleya previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielbate @nedsalk
chore: fix grammar
8bbe708 
Co-authored-by: Nedim Salkić <[email protected]>
@Torres-ssf Torres-ssf changed the title feat: imrove tx preparation for a Script and implement txId helper feat: improve tx preparation for a Script and implement txId helper Nov 28, 2023
Torres-ssf
Torres-ssf approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielbate danielbate enabled auto-merge (squash) November 28, 2023 11:15
@danielbate danielbate merged commit 4d1f623 into master Nov 28, 2023
10 checks passed
@danielbate danielbate deleted the db/feat/add-tx-id-helper-and-improve-script-dx branch November 28, 2023 11:15
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

Assignees

@danielbate danielbate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve DX for Script class
4 participants
@danielbate @arboleya @nedsalk @Torres-ssf