Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement browser testing #1431

Closed
wants to merge 172 commits into from

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Nov 13, 2023

arboleya and others added 30 commits August 26, 2023 19:46
@arboleya arboleya added the feat Issue is a feature label Dec 8, 2023
@arboleya arboleya added this to the Beetle milestone Dec 14, 2023
@arboleya arboleya removed the blocked label Dec 14, 2023
@danielbate danielbate changed the base branch from master to rc/salamander January 3, 2024 10:07
@danielbate danielbate mentioned this pull request Jan 4, 2024
44 tasks
@arboleya arboleya modified the milestones: 2 - Beetle, 1 - Salamander Jan 8, 2024
__esModule: true,
...jest.requireActual('child_process'),
}));
vi.mock('child_process', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally believe the following format is more readable

vi.mock('child_process', async () => ({
  __esModule: true,
  ...await vi. importActual('child_process'),
}));

const initialDependencies: { file: string; contents: string }[] = [];

/**
* - Needs refactoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

.mockResolvedValue({
chain: {} as ChainInfo,
nodeInfo: {} as NodeInfo,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbate why has this changees out of curiosity?

@danielbate
Copy link
Member Author

Superceded by #1630

@danielbate danielbate closed this Jan 10, 2024
@arboleya arboleya deleted the db/feat/implement-browser-testing-v2 branch February 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Buffer compatibility for browsers Create test to browser compatibility
3 participants