Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement GraphQL subscriptions support #1256

Merged
merged 64 commits into from
Sep 25, 2023
Merged

feat: implement GraphQL subscriptions support #1256

merged 64 commits into from
Sep 25, 2023

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 14, 2023 •
edited
Loading

This PR introduces support for subscriptions to our nodes and replaces TransactionResponse's waiting mechanisms with subscriptions instead of polling.

Note: nodejs and pnpm versions have been updated in this PR as well. Please run nvm install and nvm use after this PR is merged.

closes #782,
closes #301

nedsalk added 25 commits August 17, 2023 12:02
@nedsalk
checkpoint
ba88350
@nedsalk
checkpoint save
d397211
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
6efb354 
…o-transaction-status-changes
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
0eb5c90 
…o-transaction-status-changes
@nedsalk
feat: got subscriptions to work
560777d
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
b49b12b 
…o-transaction-status-changes
@nedsalk
feat: got subscriptions working in .waitForResult()
9bb7517
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
ebb7566 
…o-transaction-status-changes
@nedsalk
checkpoint: timeouts
aad8a3d
@nedsalk
checkpoint
af26fa7
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
a69916a 
…o-transaction-status-changes
@nedsalk
test: when subscription gets node error
f32fedf
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
88794ef 
…o-transaction-status-changes
@nedsalk
chore: formatter changed from double to single-tick
a5ec769
@nedsalk
fix: reverted unnecessary change
da7f7d2
@nedsalk
chore: removed specified typescript version to use the global one
a218c57
@nedsalk
fix: reverted change to file after testing
bb7fc28
@nedsalk
refactor: renamed type
5fa9206
@nedsalk
refactor: removed unused fields and vars
a7f842d
@nedsalk
chore: reasoning behind error throwing in onMessage
8f3c734
@nedsalk
test: beter test for custom fetch fn
a1c03be
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
5f2c39a 
…o-transaction-status-changes
@nedsalk
fix: updated nextjs ts version
4fd4df3
@nedsalk
test: removed redundant test
212712f
@nedsalk
Merge remote-tracking branch 'origin/master' into ns/feat/subscribe-t…
9158bdb 
…o-transaction-status-changes
@nedsalk nedsalk self-assigned this Sep 14, 2023
nedsalk
nedsalk commented Sep 14, 2023
View reviewed changes
.eslintrc.js Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.82% (+0.41% 🔼)
 5159/6082
🟡 Branches
66.11% (+0.15% 🔼)
 757/1145
🟡 Functions
75.04% (+1.34% 🔼)
 848/1130
🟢 Lines
84.71% (+0.25% 🔼)
 4940/5832
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / byte.ts
 96.55% 50% 100% 96.55%
🟢
... / raw-slice.ts
 95.24% 0% 100% 95.24%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / transaction-response.ts
17.5% (-4.72% 🔻)
 0% 0%
17.95% (-4.27% 🔻)
🔴
... / utils.ts
40% (-6.15% 🔻)
 0% 0%
35.71% (-5.95% 🔻)

Test suite run success

1224 tests passing in 213 suites.

Report generated by 🧪jest coverage report action from 247d38d

nedsalk
nedsalk commented Sep 21, 2023
View reviewed changes
package.json Show resolved Hide resolved
camsjams
camsjams previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nedsalk nedsalk requested a review from camsjams September 22, 2023 05:28
@nedsalk nedsalk enabled auto-merge (squash) September 22, 2023 05:28
@nedsalk nedsalk changed the title feat: implement GraphQL subscriptions feat: implement GraphQL subscriptions support Sep 25, 2023
@nedsalk nedsalk merged commit 0a341f1 into master Sep 25, 2023
@nedsalk nedsalk deleted the ns/feat/subscribe-to-transaction-status-changes branch September 25, 2023 15:48
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@arboleya arboleya mentioned this pull request Sep 27, 2023
Closed
nedsalk added a commit that referenced this pull request Oct 10, 2023
@nedsalk
Revert "feat: implement GraphQL subscriptions (#1256)"
c0af7a2 
This reverts commit 0a341f1.
@nedsalk nedsalk mentioned this pull request Oct 10, 2023
Merged
nedsalk added a commit that referenced this pull request Oct 10, 2023
@nedsalk
Revert "feat: implement GraphQL subscriptions (#1256)"
afe9ef4 
This reverts commit 0a341f1.
@Torres-ssf Torres-ssf mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@camsjams camsjams camsjams approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@nedsalk nedsalk

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
4 participants
@nedsalk @arboleya @camsjams @Dhaiwat10