-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return receipts in data returned by contract calls #48
Conversation
- Introduce the CallResult struct, that holds the call return in its `value` field, and the receipts in the `receipts` field.
Note: Sometimes some tests are failing but passing when I run them individually, for some weird reason (probably config issue?). |
The tests were designed to be self-contained enough so that state doesn't leak between tests. E.g. we spawn a short-lived Please provide repro steps if you found this not to be the case. Also, check it against So far I haven't experienced any flakiness in |
Edit: Issues came from commits of PR #49 , they are not on this branch so the tests run fine now! No flakiness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good! Just a few nits and comments.
CI passing as well! 🎉 |
Made the changes but Github didn't notice
Changing docs strings broke CI? wth |
Haha, that's actually what I'm currently investigating. It's failing to compile Sway code when we call forc::build during a test. So weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 😄
value
field, and the receipts in thereceipts
field.