Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return receipts in data returned by contract calls #48

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Jan 19, 2022

- Introduce the CallResult struct, that holds the call return in its
  `value` field, and the receipts in the `receipts` field.
@iqdecay iqdecay requested a review from digorithm as a code owner January 19, 2022 20:41
@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 19, 2022

Note: Sometimes some tests are failing but passing when I run them individually, for some weird reason (probably config issue?).

@digorithm
Copy link
Member

Note: Sometimes some tests are failing but passing when I run them individually, for some weird reason (probably config issue?).

The tests were designed to be self-contained enough so that state doesn't leak between tests. E.g. we spawn a short-lived fuel-core per test case in harness.rs.

Please provide repro steps if you found this not to be the case. Also, check it against master to see if this was introduced on this branch.

So far I haven't experienced any flakiness in fuels-rs tests, and if that's the case now we have to do the best we can to avoid flakiness in tests.

@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 19, 2022

Edit: Issues came from commits of PR #49 , they are not on this branch so the tests run fine now! No flakiness.

Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Just a few nits and comments.

@iqdecay iqdecay requested a review from digorithm January 20, 2022 15:07
@adlerjohn adlerjohn added the enhancement New feature or request label Jan 20, 2022
@adlerjohn adlerjohn linked an issue Jan 20, 2022 that may be closed by this pull request
@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 24, 2022

CI passing as well! 🎉

@iqdecay iqdecay dismissed digorithm’s stale review January 24, 2022 09:05

Made the changes but Github didn't notice

@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 25, 2022

Changing docs strings broke CI? wth

@digorithm
Copy link
Member

Changing docs strings broke CI? wth

Haha, that's actually what I'm currently investigating. It's failing to compile Sway code when we call forc::build during a test. So weird.

@iqdecay iqdecay requested a review from digorithm January 26, 2022 14:55
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 😄

@iqdecay iqdecay merged commit e69762e into master Jan 27, 2022
@iqdecay iqdecay deleted the vnepveu/feature-improve-call-context branch January 27, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve the data returned by contract calls
3 participants