Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use pagination in requests #1572

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: use pagination in requests #1572

merged 5 commits into from
Jan 17, 2025

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jan 14, 2025 •
edited
Loading

Summary

Use pagination for balances, contract_balances and messages requests.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@hal3e hal3e added the blocked label Jan 14, 2025
@hal3e hal3e self-assigned this Jan 14, 2025
@rafal-ch
Copy link

Corresponding PR on the core side: FuelLabs/fuel-core#2490

@digorithm
Copy link
Member

@hal3e is this good to be reviewed? Seems like the client side has been merged!

@hal3e
Copy link
Contributor Author

hal3e commented Jan 15, 2025

@hal3e is this good to be reviewed? Seems like the client side has been merged!

Yes but we will first have to review and merge this PR to support the new fuel-core

MujkicA
MujkicA previously approved these changes Jan 17, 2025
View reviewed changes
@MujkicA MujkicA self-requested a review January 17, 2025 00:21
@hal3e hal3e removed the blocked label Jan 17, 2025
@hal3e hal3e merged commit d6d6121 into master Jan 17, 2025
45 checks passed
@hal3e hal3e deleted the refactor-paginated-requests branch January 17, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MujkicA MujkicA MujkicA approved these changes

@digorithm digorithm digorithm approved these changes

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@hal3e hal3e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hal3e @rafal-ch @digorithm @MujkicA