Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: prevent implicit burn #1562

Merged
merged 14 commits into from
Jan 16, 2025
Merged

feat!: prevent implicit burn #1562

merged 14 commits into from
Jan 16, 2025

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Dec 18, 2024

Summary

TransactionBuilder will return an error on .build() if the transaction has input assets that don't have a corresponding change output. To enable burning, .enable_burn() flag has to be set to true.

Breaking Changes

Building transactions that implicitly burn coins will result in an error.
adjust_for_fee will add a base asset output consistently

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

hal3e
hal3e previously approved these changes Jan 14, 2025
Salka1988
Salka1988 previously approved these changes Jan 14, 2025
@MujkicA MujkicA dismissed stale reviews from Salka1988, hal3e, and segfault-magnet via 098d3fd January 15, 2025 20:24
@MujkicA MujkicA merged commit 5ad05ab into master Jan 16, 2025
45 checks passed
@MujkicA MujkicA deleted the feat/prevent-burn branch January 16, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants