fix: include witness data in estimation #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujkicA
requested review from
digorithm,
hal3e,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Voxelot
reviewed
Jun 13, 2024
packages/fuels-core/src/types/transaction_builders/script_dry_runner.rs
Outdated
Show resolved
Hide resolved
Voxelot
reviewed
Jun 13, 2024
packages/fuels-core/src/types/transaction_builders/script_dry_runner.rs
Outdated
Show resolved
Hide resolved
Voxelot
reviewed
Jun 13, 2024
packages/fuels-core/src/types/transaction_builders/script_dry_runner.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandon Kite <[email protected]>
…om:FuelLabs/fuels-rs into feature/include-witness-data-in-estimation
Voxelot
approved these changes
Jun 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While estimating to determine the script gas limit we use placeholders for witness data but this assumes that witness data only contains signatures which may not always be the case.
This PR makes sure the existing witnesses are retained before estimating.
Checklist