feat(macros): add SetOptions { profile } command
#1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br1ght0ne
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet and
Salka1988
as code owners
There was a problem hiding this comment.
Short and sweet, plugged in nicely at all the right places.
I'd remove strum and implement the conversion to string manually.
If it were a binary I wouldn't nitpick, but wouldn't like the dep to propagate to all users of the sdk because of "debug" and "release". Besides an extra dep, our version choice (whatever it is) might also cause headaches to any present strum dep.
segfault-magnet
previously approved these changes
Jun 4, 2024
MujkicA
previously approved these changes
Jun 4, 2024
hal3e
requested changes
Jun 5, 2024
packages/fuels-macros/src/setup_program_test/parsing/commands/set_options.rs
Outdated
Show resolved
Hide resolved
MujkicA
approved these changes
Jun 5, 2024
digorithm
approved these changes
Jun 5, 2024
Salka1988
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1360.
The command is optional, and defaults to
releaseprofile.Checklist