feat: validate predicates using the VM before sending out transaction #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
segfault-magnet
previously approved these changes
Mar 8, 2024
MujkicA
previously approved these changes
Mar 10, 2024
hal3e
requested changes
Mar 11, 2024
Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
segfault-magnet
previously approved these changes
Mar 14, 2024
Br1ght0ne
previously approved these changes
Mar 15, 2024
MujkicA
approved these changes
Mar 15, 2024
Salka1988
approved these changes
Mar 15, 2024
hal3e
approved these changes
Mar 18, 2024
segfault-magnet
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normally closes (correctly this time I hope) #1195 by adding predicates
validation within the SDK.
about to be sent to the node and prevents it.