Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use beta-5 endpoint #1245

Merged
merged 11 commits into from
May 7, 2024
Merged

chore: use beta-5 endpoint #1245

merged 11 commits into from
May 7, 2024

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Jan 10, 2024 •
edited
Loading

  • No more transient CI errors!

hal3e
hal3e previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

digorithm
digorithm reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let's hold this PR for a little bit until the beta-5 release is officially out; we don't want to accidentally release a new SDK version with these docs before people know about the beta-5.

@iqdecay iqdecay force-pushed the iqdecay/chore-use-beta5-live branch 2 times, most recently from 61596d8 to 3355250 Compare January 22, 2024 16:12
MujkicA
MujkicA reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@MujkicA MujkicA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some more mentions of beta4 in the docs debugging section. The section still makes sense with beta4, I thought I'd just note it down. Nvm, I was looking at the wrong repo

@segfault-magnet
Copy link
Contributor

Maybe to make it into a draft until things are ready? @digorithm @iqdecay

@digorithm digorithm marked this pull request as draft February 1, 2024 19:07
@segfault-magnet segfault-magnet marked this pull request as ready for review April 30, 2024 17:27
MujkicA
MujkicA previously approved these changes Apr 30, 2024
View reviewed changes
Salka1988
Salka1988 previously approved these changes May 1, 2024
View reviewed changes
@segfault-magnet segfault-magnet requested a review from MujkicA May 2, 2024 05:34
@segfault-magnet segfault-magnet requested a review from Salka1988 May 6, 2024 11:25
@hal3e hal3e merged commit fef8e2e into master May 7, 2024
41 checks passed
@hal3e hal3e deleted the iqdecay/chore-use-beta5-live branch May 7, 2024 10:46
@Br1ght0ne Br1ght0ne mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salka1988 Salka1988 Salka1988 approved these changes

@MujkicA MujkicA MujkicA approved these changes

@hal3e hal3e hal3e approved these changes

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

Assignees

@segfault-magnet segfault-magnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iqdecay @segfault-magnet @digorithm @Salka1988 @MujkicA @hal3e