-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove NetworkInfo
#1231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @hal3e. This is an awesome UX simplification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep the old name even if we sneak one more method under.
This one is too generic. Might be a sign that we're looking at two traits: DryRunner
, ChainInfoProvider
.
1d69011
Fair enough |
The main point of the trait is to provide the used amount of gas. |
I have decided to leave the name |
When building a transaction with the SDK we currently ask for both
NetworkInfo
and aprovider
when building.NetworkInfo
is redundant as we can fetch all necessary information from theprovider
while building.BREAKING CHANGE:
NetworkInfo
and all related functions/methodsDryRunner
trait and added trait methodsScritpTransactionBuilder::new
andCreateTransactionBuilder::new
Provider::new
Checklist