-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improve transaction builders wrt TxPolicies
#1212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujkicA
reviewed
Nov 23, 2023
MujkicA
reviewed
Nov 23, 2023
MujkicA
reviewed
Nov 23, 2023
MujkicA
reviewed
Nov 23, 2023
MujkicA
reviewed
Nov 23, 2023
MujkicA
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some questions
Br1ght0ne
approved these changes
Nov 23, 2023
digorithm
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean, great job!
Salka1988
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the usage of
TxPolicies
and fixes some of the issues that remained after their were introduced.BREAKING CHANGE:
ScriptTransactionBuilder
andCreateTransactionBuilder
do not havewith_maturity
andwith_gas_price
, (with_gas_limit
). They are set through thewith_tx_policies
method.Maturity
is not set to0
by default - instead we use anOption<u64>
andNone
if it was not set. This saves bytes as it is not serialized ifNone
WitnessLimit
is set to the size of all witnesses in the builder. If the user usesappend_witnesses
after finalizing the transaction a new error will be returned that helps the user set the witness limit manually.Checklist