Handle return data larger than a word #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the returned data from a contract call is larger than a word, it isn't stored in `Return.val`, but in `ReturnData.data`. Before the changes in here, we were pulling the data only from `Return.val`, which fortunately handled most cases. Until now, with some methods returning, for instance, a `b256`, which would cause the data to _not_ be in `Return.val` as we expected, leading to errors. This PR introduces some changes to fix this by looking whether the expected return type is larger than a word, if it is, we fetch the returned data from `ReturnData.data` instead of `Return.val`.
|
@nfurfaro tagging you in this PR because it fixes the issue you found and includes the test cases you used to find the problem. These test cases are now part of the test suite for the SDK. |
iqdecay
suggested changes
Feb 25, 2022
fuels-abigen-macro/tests/test_projects/large-return-data/abi.json
Outdated
Show resolved
Hide resolved
iqdecay
approved these changes
Feb 25, 2022
This was referenced Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the returned data from a contract call is larger than a word,
it isn't stored in
Return.val, but inReturnData.data.Before the changes in here, we were pulling the data only from
Return.val, which fortunately handled most cases. Until now,with some methods returning, for instance, a
b256, which would causethe data to not be in
Return.valas we expected, leading to errors.This PR introduces some changes to fix this by looking whether the
expected return type is larger than a word, if it is, we fetch the
returned data from
ReturnData.datainstead ofReturn.val.