Skip the panic reason from canonical serialization #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Dentosal
previously approved these changes
Sep 13, 2024
xgreenx
added a commit
to FuelLabs/fuel-specs
that referenced
this pull request
Sep 13, 2024
The main reason for removing it from canonical serialization is to avoid affecting the block ID for different panic reasons. The primary goal is just to know that some operation was done incorrectly; what exactly failed is less important. It reduces the chance of getting different blocks within one panic. Related VM change: FuelLabs/fuel-vm#826 ### Before requesting review - [x] I have reviewed the code myself
netrome
previously approved these changes
Sep 16, 2024
Dentosal
approved these changes
Sep 16, 2024
netrome
approved these changes
Sep 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related specification PR: FuelLabs/fuel-specs#609
The main reason for removing it from canonical serialization is to avoid affecting the block ID for different panic reasons. The primary goal is just to know that some operation was done incorrectly; what exactly failed is less important. It reduces the chance of getting different blocks within one panic.
Checklist
Before requesting review