Versioning of ConsensusParameters and GasCosts
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced default `MAX_SIZE` to be 110kb. Reduced default `MAX_CONTRACT_SIZE` to be 100kb.
Dentosal
reviewed
Mar 21, 2024
| pub base_asset_id: AssetId, | ||
| pub enum ConsensusParameters { | ||
| /// Version 1 of the consensus parameters | ||
| V1(ConsensusParametersV1), |
There was a problem hiding this comment.
Should we consider #[non_exhaustive] here?
There was a problem hiding this comment.
No, since serve will handle it=)
Dentosal
reviewed
Mar 21, 2024
|
|
||
| /// Arbitrary default consensus parameters. While best-efforts are made to adjust these to | ||
| /// reasonable settings, they may not be useful for every network instantiation. | ||
| #[deprecated(since = "0.12.2", note = "use `ConsensusParameters` instead.")] |
Dentosal
approved these changes
Mar 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related FuelLabs/fuel-core#1753
Wrapped
ConsensusParametersandGasCostsinto an enum to support versioning.Moved
block_gas_limitfromfuel_core_chain_config::ChainConfigtoConsensusPataremeters.Reduced default
MAX_SIZEto be 110kb - related FuelLabs/fuel-core#1761.Reduced default
MAX_CONTRACT_SIZEto be 100kb - related FuelLabs/fuel-core#1761.